[b6] Repeatable Crash In Alter View/autocomplete

[jrossiter]

Using the view code below, begin adding a new field by typing

Code:

`msgs.quar_type` AS `Quarantine`

(Yes, I'm aware the format is wrong and it needs to be `msgs`.`quar_type`, but just try it.)

Immediately after typing the . SQLYog crashes without so much as a GPF dialog. Using the correct format of `msgs`. doesn't cause a crash. (However, it doesn't display auto-complete, either.) It doesn't really matter, but for reproduction's sake, I was adding the field after 'Whitelist'.

Code:

DELIMITER $$;

DROP VIEW IF EXISTS `amavisd`.`Mail Summary`$$

CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`192.168.12.%` SQL SECURITY DEFINER VIEW `Mail Summary` AS (select date_format(from_unixtime(`msgs`.`time_num`),get_format(DATETIME, _latin1'USA')) AS `Time`,`mas`.`email` AS `Sender`,`mar`.`email` AS `Recipient`,`msgs`.`spam_level` AS `SpamScore`,`msgrcpt`.`bl` AS `Blacklist`,`msgrcpt`.`wl` AS `Whitelist`,`msgs`.`quar_type` AS `Quarantine`,`msgs`.`client_addr` AS `ClientIP`,`msgs`.`subject` AS `Subject` from (((`msgrcpt` join `msgs` on((`msgs`.`mail_id` = `msgrcpt`.`mail_id`))) join `maddr` `mar` on((`mar`.`id` = `msgrcpt`.`rid`))) join `maddr` `mas` on((`mas`.`id` = `msgs`.`sid`))) order by date_format(from_unixtime(`msgs`.`time_num`),get_format(DATETIME, _latin1'USA')))$$

DELIMITER;$$

[peterlaursen]

This crash is reproducable here .. even when I don't have the TAGs file of yours.

To reproduce

1) copy the complete view definition to editor

2) delete `msgs`.`quar_type` AS `Quarantine`,

3) type `msgs.

and it crashes.

If I only type the `msgs. into an empty editor there is no crash

Let me point here to two more issues with autocomplete.

(1 is more important than 2. Actually I think 1) is a blunder )

1)

select * from ta finds table_name

but

select * from `ta does not.

I think autocomplete should strip backticks before evaluating

2)

select * from table_name where co

finds “column_name” but not “column.name.“

I think punctuations are valid inside a columnname ??

[Ritesh]

Point 1 and 2 will be fixed today.

I can get point 3. I think you are getting them too as posted in another topic.

[Author]

Posts