Custom Filter Improvements

[peterlaursen]

1) Personally I'd prefer this then “Change the default to the condition you last used” (in both plain filter' and 'custom filter'). The 'preferences can easily get cluttered with a lot as such 'small' options.

2) Yes .. it is a little inconsistent that we have in 'plain filter' both 'string', '%string', 'string%' and '%string%' options wiht LIKE but no similar option for user in 'custom filter'. I don't know if we could activate a combo/dordown i LIKE operator is chosen or if we should find another another implementation or redesign the 'custom filter' dialog.

[Laurence Jones]

'peterlaursen' wrote:

1) Personally I'd prefer this then “Change the default to the condition you last used” (in both plain filter' and 'custom filter'). The 'preferences can easily get cluttered with a lot as such 'small' options.

2) Yes .. it is a little inconsistent that we have in 'plain filter' both 'string', '%string', 'string%' and '%string%' options wiht LIKE but no similar option for user in 'custom filter'. I don't know if we could activate a combo/dordown i LIKE operator is chosen or if we should find another another implementation or redesign the 'custom filter' dialog.

Thanks for the reply… sorry for the delay in mine!!

1) Yes, I believe changing the default would be perfect!

2) With regard to the LIKE %string% option, so long as it defaults to the one you last used, I am not too worried how fiddly it is to select the option the first time. I would suggest though that the simplest would be to expand the current selection to include:

=

>

<

LIKE value

LIKE %value%

Personally I don't think that %value or value% are something that a user would want as a default and therefore could type in the % on those occasions.

All the best

Laurence

[peterlaursen]

I believe that we escape if user types a '%' or a '-' (ie. pass to mysql_real_escape_string http://dev.mysql.com…pe-string.html. What means that we are filtering on those wildcard characters as a literal. Because

1) It makes perfect sense to filter on “14%” (sent to the server as “14%”) for instance meaning “14 percent”.

2) The filter is supposed to be fully GUI and should not require user to handle MySQL escape syntax.

[Laurence Jones]

'peterlaursen' wrote:

I believe that we escape if user types a '%' or a '-' (ie. pass to mysql_real_escape_string http://dev.mysql.com/doc/refman/5.1/en/mysql-real-escape-string.html. What means that we are filtering on those wildcard characters as a literal. Because

1) It makes perfect sense to filter on “14%” (sent to the server as “14%”) for instance meaning “14 percent”.

2) The filter is supposed to be fully GUI and shouldnot require user to handle MySQL escape syntax.

I do not believe that is correct Peter – if I search for LIKE and enter %abc%, it finds all items with the field containing “abc” not “%abc%”.

If you are infering you intend to make that change, please do not! I for instance would quite frequently search for things like “%EPSON%RED%” to find red cartridges – if you escaped the %, this would not be possible and would be a far worse than an inconvenience.

[peterlaursen]

I have to admit that I did not check!

In 'Data Search' we do escape. So this is an inconsistence! We do not plan any immediate changes either place though.

[peterlaursen]

I have added to our issue tracker this: http://code.google.com/p/sqlyog/issues/detail?id=1698

But unlikely there will be a change in either for the next 3-4 months at least.

[Laurence Jones]

'peterlaursen' wrote:

I have added to our issue tracker this: http://code.google.com/p/sqlyog/issues/detail?id=1698

But unlikely there will be a change in either for the next 3-4 months at least.

Is there any chance you can also request the default to last used operand in the filter?

[peterlaursen]

Also added. http://code.google.com/p/sqlyog/issues/detail?id=1699. But no timeframe guaranteed.

[Laurence Jones]

Many thanks!

[Author]

Posts